create StorageCluster peer token secret on the hub #228
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Umanga Chapagain <[email protected]>
umangachapagain
force-pushed
the
onboarding-token-exchange
branch
from
25fdcf2 to
4dc2459
Compare
umangachapagain
force-pushed
the
onboarding-token-exchange
branch
from
d35c3d6 to
8d6500e
Compare
Signed-off-by: Umanga Chapagain <[email protected]>
umangachapagain
force-pushed
the
onboarding-token-exchange
branch
from
8d6500e to
e68c54f
Compare
| var odfOperatorNamespace string | ||
| if utils.HasRequiredODFKey(cluster) { | ||
| odfOperatorNamespacedName, err := utils.GetNamespacedNameForClusterInfo(*cluster) | ||
| if err != nil { | ||
| return objects, fmt.Errorf("error while getting ODF operator namespace on the spoke cluster %q. %w", cluster.Name, err) | ||
| } | ||
| odfOperatorNamespace = odfOperatorNamespacedName.Namespace | ||
| } else { | ||
| return objects, fmt.Errorf("error while getting ODF operator namespace on the spoke cluster %q. Expected ClusterClaim does not exist", cluster.Name) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why not just use addon.Spec.InstallNamespace ? We are always creating the addons in ODF's namespace
There was a problem hiding this comment.
Even for Provider consumer cases, We will be doing the same. Fetching the namespace again would be redundant operation
https://github.com/red-hat-storage/odf-multicluster-orchestrator/pull/221/files#diff-71a31664c2a326d791c6040801a670cc01383300df3e4378f843bb619d2ea4e8R410-R440
There was a problem hiding this comment.
You are assuming that addon install namespace will be same as ODF operator namespace. That might not always be true. Instead I am allowing a way to change it dynamically.
There was a problem hiding this comment.
@umanga I feel that fetching ODF namespace does not make sense in the manifests func for setting up addons.
Can we make it so that it is calculated by the MirrorPeer and sent further as a configuration option?
If there's no time, then we can merge it and design later.
|
/lgtm |
|
/test integration-test |
openshift-merge-bot
bot
merged commit b3df88c
into
red-hat-storage:main
No description provided.